-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add 'CONTAIN' support in query builder #117
Conversation
dao-impl/elasticsearch-dao-7/src/main/java/com/linkedin/metadata/dao/utils/SearchUtils.java
Outdated
Show resolved
Hide resolved
There seems to be something off here. Why do I see diff from @kaliang1 in this PR? |
045cfe2
to
6de161d
Compare
dao-impl/elasticsearch-dao/src/main/java/com/linkedin/metadata/dao/utils/SearchUtils.java
Outdated
Show resolved
Hide resolved
This fix to address the issue #114
6de161d
to
200ebfe
Compare
dao-impl/elasticsearch-dao-7/src/main/java/com/linkedin/metadata/dao/utils/SearchUtils.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, the current query template supports advanced query as well, so that user can just issue *text? https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html
Good to know! It could be good for advance users. This specific ask is for supporting CONTAIN with sbustring query, we prefer to have explicit filter options (CONTAIN, START_WITH, END_WITH) to users and hide ES internal details such as ''. If users knows they are looking for START_WITH, then using START_WITH will perform better as the underlying query pattern is _wildcard_query(term)_. Exposing * to users may lead to complexity and out of controlled use cases such as searching on "ABCD*"..etc. |
|
This fix to address the issue #114
Checklist