Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translate tag #543

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update translate tag #543

wants to merge 2 commits into from

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Sep 9, 2024

Update translate tag.

Going forward, the translate tag is the recommended version so we update things for clarity.

https://docs.djangoproject.com/en/3.2/topics/i18n/translation/#std:templatetag-translate

The trans tag was renamed to translate. The trans tag is still supported as an alias for backwards compatibility.

This will also help remove a bit of noise in #520 regarding some lines that only change the tag.

kfdm added 2 commits September 9, 2024 17:13
Going forward, the translate tag is the recommended version so we update
things for clarity.

https://docs.djangoproject.com/en/3.2/topics/i18n/translation/#std:templatetag-translate

> The trans tag was renamed to translate. The trans tag is still supported as an alias for backwards compatibility.
While it's a code change in a sense, the change is changing an alias.
Adding it to the blame ignore will make it easier to view actual changes
in the diff views.
@kfdm kfdm requested a review from a team as a code owner September 9, 2024 08:15
@vincent-olivert-riera
Copy link
Contributor

@kfdm , I would like to merge this PR. Could you rebase it on master and fix the conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants