Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for URL rendering #536

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Add test for URL rendering #536

merged 1 commit into from
Jul 29, 2024

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Jul 29, 2024

Similar to our previous PR, we want to add some starting test cases to our url rendering paths so that we are prepared for future updates.

@kfdm kfdm requested a review from a team as a code owner July 29, 2024 03:44
Copy link
Contributor

@vincent-olivert-riera vincent-olivert-riera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just made an optional request.

promgen/templates/promgen/navbar.html Outdated Show resolved Hide resolved
Similar to our previous PR, we want to add some starting test cases to
our url rendering paths so that we are prepared for future updates.
@kfdm kfdm merged commit 968d142 into line:master Jul 29, 2024
5 checks passed
@kfdm kfdm deleted the url-render-test branch July 29, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants