Convert silence_row into a Vue component #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help with future development around the Silence area. The component allows choosing the color of the matchers, and also emits an event when a matcher is clicked. That way we can reuse the component for multiple purposes, displaying the matchers in a different color and doing an different action when a matcher is clicked. A few bits had to be added in order to maintain the current style, such as the template and tbody tags.
kfdm
reviewed
Jul 29, 2024
kfdm
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help with future development around the Silence area.
The component allows choosing the color of the matchers, and also emits an event when a matcher is clicked. That way we can reuse the component for multiple purposes, displaying the matchers in a different color and doing an different action when a matcher is clicked.
A few bits had to be added in order to maintain the current style, such as the template and tbody tags.