Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow testing notifiers before registering them #419

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vincent-olivert-riera
Copy link
Contributor

This commit adds a new "Test" button next to the one for registering a notifier, so the user can use it to test if the notifier they are about to register actually works.

Example of success:

Screenshot 2022-12-20 at 19-04-30 Promgen 0 57 0 dev

Example of error:

Screenshot 2022-12-20 at 19-03-59 Promgen 0 57 0 dev

@vincent-olivert-riera vincent-olivert-riera requested a review from a team as a code owner December 20, 2022 10:10
This commit adds a new "Test" button next to the one for registering a notifier,
so the user can use it to test if the notifier they are about to register
actually works.
@kfdm kfdm self-assigned this Jan 18, 2023
Cosmetic fixup for a misformatting I found while self-reviewing the PR.
@sh-kawakami
Copy link
Contributor

@vincent-olivert-riera I think that this function we should implement and It looks fine. But please check these code can merge currently(because from make this PR, long time pasted.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants