Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves #268.
The conflict was not in the prettier settings per se. Instead, when
lint-staged
is run as the last step before a commit, it is invoked using npx and the remote config is using the json parser on JSON files. The other tooling for the repo, most specifically vscode, uses json-stringify for the JSON parser.This difference in parsers was causing the locally-built (via build script) and committed JSON task files to be reformatted with arrays on a single line. Using the json-stringify parser will instead keep the arrays as multiline, which aligns with how all of the JSON task files have existed in the library prior to adding prettier to the repo.
To preserve the usage of Shopify's prettier settings, a new
prettier.config.js
file was created to import and export those settings while adding an override on the JSON parser.This commit also updates the affected task JSON files that were committed since the prettier addition.