new task: send tax receipts for donations #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhughes27
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
LGTM! I tested a donation on my shop and it worked great 😄
There are a few more advanced use cases that aren't covered (like discounts, tips and products where only a percentage of the cost is considered a donation) but that is fine - the code of the task is very clear and easy enough to extend by the user for those cases.
Thanks for adding this!
|
@kevinhughes27 Thank you for the review. I'll go ahead and merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task allows a shop that is taking donations as order transactions to send tax receipts to the donors (customers).