set dont forward bit in chanupdate msg for private channels #8582

ziggie1984 · 2024-03-25T20:05:59Z

Replaces #7759

Need to address this comment for that PR to be ready for master: #7759 (comment)

PR is based on #8777

and

#9384

coderabbitai · 2024-03-25T20:06:11Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

discovery/gossiper.go

ziggie1984 · 2024-12-18T17:22:57Z

Hold on with your review still, first the dependant PR need to pass the tests and then this one.

This will make it simple in the next commits to test soley single messages rather than always the combination of announcement and channel update msg.

When the option SCID is used we need to make sure we update the channel data in an atomic way so that we don't miss any updates by our peer and remove all edge info which still uses the alias as the channel id (e.g. ChannelUpdate msgs). Moreover add unit test for the new ReAddEdge method.

In case we assume valid channels or have alias channels we make sure we also add the channel point to the block filter so that we are notified if the channel point is spent in a block.

We almost never need to create all messages at the same time (ChanUpdate,ChanAnnouncement,Proof) so we split it up into own functions.

new msg flag in the channel update msg is defined.

Set the dont_forward bit in the chan update msg when a channel is not (yet) announced to the network. This is either the case for channels which signal this in the ChannelFlags of the OpenChannel msg but also for public channels which have still not reached the minimum depth height of 6 confirmations.

Adopt tests to make sure the dont_forward bit is set when needed.

When a channel update is now executed the msg field will be migrated on the fly meaning that private channels or channels which still have no signatures exchanged will now signal the dont_forward bit.

In case the __dont_forward__ is set in the ChanUpdate msg lnd will not forward this msg to the gossiper hence broadcasting it to all its peers. This makes sure we follow the network rules and dont forward ChanUpdates which do not signal it.

lightninglabs-deploy · 2024-12-25T18:06:50Z

@ziggie1984, remember to re-request review from reviewers when ready

ziggie1984 force-pushed the dont-forward-bit branch from 42dfa2c to 5f46805 Compare March 25, 2024 20:17

saubyk assigned ziggie1984 Mar 25, 2024

ziggie1984 force-pushed the dont-forward-bit branch from 5f46805 to d16859f Compare March 25, 2024 20:24

saubyk added this to the v0.18.1 milestone May 9, 2024

saubyk linked an issue May 9, 2024 that may be closed by this pull request

[spec]: start to set the dont_forward bit in ChannelUpdate #7416

Open

ziggie1984 mentioned this pull request May 24, 2024

multi: make reassignment of alias channel edge atomic #8777

Open

saubyk added the P2 should be fixed if one has time label Jun 25, 2024

saubyk modified the milestones: v0.18.3, v0.19.0 Jul 11, 2024

MPins reviewed Dec 10, 2024

View reviewed changes

discovery/gossiper.go Outdated Show resolved Hide resolved

ziggie1984 force-pushed the dont-forward-bit branch 2 times, most recently from cc528d4 to ee97b15 Compare December 18, 2024 15:22

ziggie1984 added P1 MUST be fixed or reviewed and removed P2 should be fixed if one has time labels Dec 18, 2024

ziggie1984 requested review from starius and yyforyongyu December 18, 2024 15:24

ziggie1984 force-pushed the dont-forward-bit branch from ee97b15 to 578f47d Compare December 18, 2024 17:22

ziggie1984 marked this pull request as ready for review December 18, 2024 17:23

ziggie1984 added gossip size/kilo medium, proper context needed, less than 1000 lines labels Dec 18, 2024

ziggie1984 force-pushed the dont-forward-bit branch from 578f47d to 76d44d8 Compare December 19, 2024 22:23

ziggie1984 changed the base branch from master to yy-waiting-on-merge December 19, 2024 22:24

yyforyongyu force-pushed the yy-waiting-on-merge branch 4 times, most recently from 4430487 to e885bf5 Compare December 20, 2024 09:54

ziggie1984 added 2 commits December 20, 2024 12:28

funding: refactor testcase

01c09ec

This will make it simple in the next commits to test soley single messages rather than always the combination of announcement and channel update msg.

ziggie1984 added 5 commits December 20, 2024 12:36

lnwire: add string method to channel_ready type

ce27b34

graph: add channel point to utxo filter

48f7842

In case we assume valid channels or have alias channels we make sure we also add the channel point to the block filter so that we are notified if the channel point is spent in a block.

graph: fix log output

55a4ab6

docs: add release-notes

fc0a477

channeldb: fix typo.

115451c

yyforyongyu force-pushed the yy-waiting-on-merge branch from e885bf5 to 2913f6e Compare December 20, 2024 11:38

funding: refactor gossip msg code

681ab29

We almost never need to create all messages at the same time (ChanUpdate,ChanAnnouncement,Proof) so we split it up into own functions.

ziggie1984 changed the base branch from yy-waiting-on-merge to master December 20, 2024 11:43

ziggie1984 force-pushed the dont-forward-bit branch from 76d44d8 to 898ad3e Compare December 20, 2024 11:49

ziggie1984 added 2 commits December 20, 2024 13:01

lnwire: Define new dont_forward bit in msg flags

c0c3e94

new msg flag in the channel update msg is defined.

ziggie1984 force-pushed the dont-forward-bit branch from 898ad3e to f7fe057 Compare December 20, 2024 12:01

ziggie1984 added 5 commits December 22, 2024 01:46

funding: adopt tests for the dont_forward bit

0ebedcb

Adopt tests to make sure the dont_forward bit is set when needed.

localchans: set dont_forward bit in chan update msg

d71a1c8

When a channel update is now executed the msg field will be migrated on the fly meaning that private channels or channels which still have no signatures exchanged will now signal the dont_forward bit.

discovery: dont_forward bit in msg flag.

828edf9

In case the __dont_forward__ is set in the ChanUpdate msg lnd will not forward this msg to the gossiper hence broadcasting it to all its peers. This makes sure we follow the network rules and dont forward ChanUpdates which do not signal it.

routing: fix typo and log msg. and log msg.

146bfb8

docs: update release-docs

6bbd9a4

ziggie1984 force-pushed the dont-forward-bit branch from f7fe057 to 6bbd9a4 Compare December 22, 2024 09:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

set dont forward bit in chanupdate msg for private channels #8582

set dont forward bit in chanupdate msg for private channels #8582

ziggie1984 commented Mar 25, 2024 •

edited

Loading

coderabbitai bot commented Mar 25, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

ziggie1984 commented Dec 18, 2024

lightninglabs-deploy commented Dec 25, 2024

set dont forward bit in chanupdate msg for private channels #8582

Are you sure you want to change the base?

set dont forward bit in chanupdate msg for private channels #8582

Conversation

ziggie1984 commented Mar 25, 2024 • edited Loading

coderabbitai bot commented Mar 25, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

ziggie1984 commented Dec 18, 2024

lightninglabs-deploy commented Dec 25, 2024

ziggie1984 commented Mar 25, 2024 •

edited

Loading

coderabbitai bot commented Mar 25, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)