.github: bump upload-artifact action to v4 #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
added
the
no-changelog
bitromortac
approved these changes
Jan 10, 2025
ViktorTigerstrom
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
actions/upload-artifact@v3is (or it seems might already be) deprecated.As per the migration notes, the only thing to be aware of is that we need to take care to namespace artifacts correctly so that jobs in the same CI run dont overwrite the artifacts of other jobs with the same name. Luckily in Lit, we only have 1 possible artifact at the moment so no worries re namespacing at the moment. When we start adding different DB backends, then this will come into play