Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poetry deprecation fixes #642

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Poetry deprecation fixes #642

merged 2 commits into from
Jan 8, 2025

Conversation

daywalker90
Copy link
Contributor

@daywalker90 daywalker90 commented Jan 6, 2025 •
edited
Loading

I saw some fresh problems in the CI with poetry in python 3.11:

The command "export" does not exist.

Warning: The current project could not be installed: No file/folder found for package cln-meta-project
If you do not want to install the current project use --no-root.

I remembered this deprecation warning:

Warning: poetry-plugin-export will not be installed by default in a future version of Poetry.
In order to avoid a breaking change and make your automation forward-compatible, please install poetry-plugin-export explicitly. See https://python-poetry.org/docs/plugins/#using-plugins for details on how to install a plugin.

So i added the dependency manually aswell as the --no-root. Let's hope it doesn't break the other versions.

@daywalker90 daywalker90 force-pushed the python-deprecation-fixes branch from 0e9b131 to b71171e Compare January 6, 2025 22:36
@daywalker90 daywalker90 force-pushed the python-deprecation-fixes branch from b71171e to d08ddb1 Compare January 7, 2025 10:42
@daywalker90 daywalker90 changed the title Python deprecation fixes Poetry deprecation fixes Jan 7, 2025
chrisguida
chrisguida approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@chrisguida chrisguida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chrisguida chrisguida merged commit ac75ccc into lightningd:master Jan 8, 2025
7 checks passed
@chrisguida
Copy link
Collaborator

Maybe we could update to poetry 2.0? https://python-poetry.org/blog/announcing-poetry-2.0.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisguida chrisguida chrisguida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daywalker90 @chrisguida