-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch eval metrics to markdown #1706
Patch eval metrics to markdown #1706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your PR! I left some comments on how I believe we could simplify it a bit but the code overall looks very good.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1706 +/- ##
=======================================
Coverage 84.90% 84.90%
=======================================
Files 156 156
Lines 6526 6526
=======================================
Hits 5541 5541
Misses 985 985 ☔ View full report in Codecov by Sentry. |
e6b3b5a
to
3a406ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much, this looks great!
TODO's:
Collect metrics over the whole benchmark:
prints the results like:
(values randomly generated and passed to the function)
which prints markdown like,
potentially fixes #1333