Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docstring for lightly/embedding subpackage #1682

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Prathamesh010
Copy link
Contributor

Fixes #1670

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.74%. Comparing base (820b20f) to head (80329c5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1682   +/-   ##
=======================================
  Coverage   84.74%   84.74%           
=======================================
  Files         153      153           
  Lines        6465     6465           
=======================================
  Hits         5479     5479           
  Misses        986      986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@SauravMaheshkar SauravMaheshkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prathamesh010 could you run make format, and commit again. black seems to be failing on CI. Remember to use the same version as the one mentioned in pyproject.toml

@Prathamesh010
Copy link
Contributor Author

Prathamesh010 commented Oct 8, 2024

I ran make format on the files. @SauravMaheshkar Please check now

Copy link
Collaborator

@SauravMaheshkar SauravMaheshkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ☕

@SauravMaheshkar SauravMaheshkar merged commit 4dfcad8 into lightly-ai:master Oct 8, 2024
12 checks passed
payo101 pushed a commit to payo101/lightly that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup docstrings in lightly/embedding subpackage.
2 participants