Addition of Random frequency mask transform #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1680 +/- ##
==========================================
+ Coverage 84.74% 84.78% +0.03%
==========================================
Files 153 154 +1
Lines 6465 6480 +15
==========================================
+ Hits 5479 5494 +15
Misses 986 986 ☔ View full report in Codecov by Sentry. |
guarin
requested changes
Oct 8, 2024
* Replace lambda functions with named functions in the examples
* Move public classes and functions to top in lightly/data * Move public classes and functions to top in lightly/models/modules * Move public classes and functions to top in lightly/utils * Move public classes and functions to top in lightly/loss * Reformat after black failure --------- Co-authored-by: Saurav Maheshkar <[email protected]>
|
@guarin @philippmwirth I have made the changes, could you guys review the PR now? |
guarin
requested changes
Oct 9, 2024
|
Done @guarin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified file(s)
lightly/transforms/__init__.py: Added new transform importslightly/transforms/random_crop_and_flip_with_grid.py: Resolvedmypyissue forAnysubclassingCreated file(s)
lightly/transforms/random_frequency_mask_transform.pytests/transforms/test_random_frequency_mask_transform.pyCloses: #1660