typecheck(cli/_helpers.py)

[ishaanagw]

No description provided.

[ishaanagw]

Partially fixes - #1635

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (e3d8795) to head (e24f20b).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1667   +/-   ##
=======================================
  Coverage   84.74%   84.75%           
=======================================
  Files         153      153           
  Lines        6465     6467    +2     
=======================================
+ Hits         5479     5481    +2     
  Misses        986      986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MalteEbner]

Great initiative, I love it :)

The type-checker found some additional typings to be made, see the GitHub action here.

To reproduce it locally for easy development, just run make type-check.
Alternatively, just run mypy lightly/cli/_helpers.py directly.

You might need to install mypy and some typing backages beforehand. For the packages and versions, see

lightly/pyproject.toml

Lines 85 to 87 in cb4f1f6

	"mypy==1.4.1", # frozen version to avoid differences between CI and local dev machines
	"types-python-dateutil",
	"types-toml",

[ishaanagw]

Working on the fix to the failed type checks.
Will be interesting to find out why mypy gives all the checks as passed, please let me know if you know the reason for this ?

[SauravMaheshkar]

Working on the fix to the failed type checks. Will be interesting to find out why mypy gives all the checks as passed, please let me know if you know the reason for this ?

Make sure to use the same version as the one mentioned in pyproject.toml

lightly/pyproject.toml

Line 85 in ab77543

"mypy==1.4.1", # frozen version to avoid differences between CI and local dev machines