feat: add from_hf_dataset method
#1568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guarin
reviewed
Jul 2, 2024
Comment on lines
+235
to
+240
| def apply_transform(batch, transform=tranform, key=key): | ||
| assert key in batch.keys(), f"the provided key, {key} does not exist in the dataset" | ||
|
|
||
| batch[key] = [transform(image) for image in batch[key]] | ||
|
|
||
| return batch |
There was a problem hiding this comment.
Not sure if this works with distributed training as local functions cannot be pickled and sent to other processes. We might have to define a transform class that takes the transform and key as input.
|
@SauravMaheshkar is it ok if we close this as we now have the new tutorial from #1569 ? |
Yup closed 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new helper method to create a LightlyDataset from a HuggingFace Dataset.