-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guarin lig 3056 add mae imagenet benchmark #1263
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1263 +/- ##
==========================================
+ Coverage 85.25% 85.79% +0.54%
==========================================
Files 130 130
Lines 5519 5547 +28
==========================================
+ Hits 4705 4759 +54
+ Misses 814 788 -26 ☔ View full report in Codecov by Sentry. |
* This is required as torch.no_grad doesn't change the model configuration while manual gradient deactivation/activation can have unintended consequences. For example, MAE ViT positional embeddings are parameters with requires_grad=False that should never receive an update. But if we use activate_requires_grad for finetuning we break those parameters.
Closed
Merged
This was referenced Aug 25, 2023
Closing in favor of: #1468 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1255
Reference values from paper:
The paper uses ViT-L with 1600 epoch pretraining by default while we use only ViT-B with 100 epoch pretraining. So I would expect finetune performance to be <82.3% following Figure 7. solo-learn reports 81.6% finetune top1 for ViT-B after 100 epochs. The paper reports ViT-B finetune performance of 83.6% after 1600 epoch pretraining.
From Figure 7 it looks like linear eval should be <57.3 as we use ViT-B instead of ViT-L. ViT-B linear eval after 1600 epoch pretraining is reported as 68% in Table 12.
First Results
Results are a bit worse than expected. We should get ~82% finetune top1 but got 78.2%. Similarly for linear top1 we should get something a bit below 57% but we only got 49%.
Interestingly, knn top1 is really bad. Could be a sign that pretraining doesn't work properly or that (linear) finetuning is very important.