Throw an exception if size-in-bytes values are out of Long range #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private static boolean isValidLong(BigInteger v) { | ||
| BigInteger max = BigInteger.valueOf(Long.MAX_VALUE); | ||
| BigInteger min = BigInteger.valueOf(Long.MIN_VALUE); | ||
| return max.compareTo(v) >= 0 && min.compareTo(v) <= 0; |
There was a problem hiding this comment.
Cheaper:
v.bitLength <= 63
- use bitLength to see if we overflow Long - use BigInteger and BigDecimal to parse, instead of parseLong/parseDouble
|
Good suggestions, fixed. |
|
Going to merge this but it will only be in a 1.3.x release not a 1.2.x so I think throwing is ok. |
havocp
added a commit
that referenced
this pull request
Dec 27, 2014
Throw an exception if size-in-bytes values are out of Long range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170
Discussion on #160 suggests that we may want to only print to stderr or something (and clamp the value to Long.MAX_VALUE) rather than throwing an exception.... not sure how I feel about that.