Store type string alongside LLVM types in spec #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2over12
force-pushed
the
ian/set_context_at_entry_to_function
branch
from
55d47e9 to
59e978a
Compare
|
Sorry can you re-cherry-pick your commit over latest |
2over12
requested changes
Sep 28, 2022
| @@ -361,6 +361,7 @@ JSONTranslator::DecodeValue(const llvm::json::Object *obj, const char *desc, | |||
|
|
|||
| if (auto maybe_type_str = obj->getString("type")) { | |||
| std::string spec = maybe_type_str->str(); | |||
| decl.type_string = spec; | |||
There was a problem hiding this comment.
I think you missed doing this assignment in ParseJsonIntoCallableDecl
There was a problem hiding this comment.
Doesn't it use DecodeValue as well?
frabert
force-pushed
the
frabert/type-string-irene3
branch
from
2cbbdac to
d7eecbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.