Skip to content

Commit

Permalink
fix: remove checkExtraDataItemsCountPerTransaction from second phase
Browse files Browse the repository at this point in the history
  • Loading branch information
tamtamchik committed Dec 2, 2024
1 parent e7b546e commit 5de258b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
4 changes: 0 additions & 4 deletions contracts/0.8.9/oracle/AccountingOracle.sol
Original file line number Diff line number Diff line change
Expand Up @@ -552,10 +552,6 @@ contract AccountingOracle is BaseOracle {
}
}

IOracleReportSanityChecker(LOCATOR.oracleReportSanityChecker()).checkExtraDataItemsCountPerTransaction(
data.extraDataItemsCount
);

LEGACY_ORACLE.handleConsensusLayerReport(data.refSlot, data.clBalanceGwei * 1e9, data.numValidators);

uint256 slotsElapsed = data.refSlot - prevRefSlot;
Expand Down
3 changes: 1 addition & 2 deletions test/0.8.9/oracle/accountingOracle.submitReport.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -373,8 +373,7 @@ describe("AccountingOracle.sol:submitReport", () => {
});

context("enforces data safety boundaries", () => {
// TODO: restore test, but it is suspected to be inrelevant, must revert as it actually does
it.skip("passes fine when extra data do not feet in a single third phase transaction", async () => {
it("passes fine when extra data do not feet in a single third phase transaction", async () => {
const MAX_ITEMS_PER_EXTRA_DATA_TRANSACTION = 1;

expect(reportFields.extraDataItemsCount).to.be.greaterThan(MAX_ITEMS_PER_EXTRA_DATA_TRANSACTION);
Expand Down

0 comments on commit 5de258b

Please sign in to comment.