Merge pull request #397 from lichess-org/code-golf/2

Minor code hygiene
lichess-org · Dec 23, 2024 · 3d7ea31 · 3d7ea31
2 parents ad65d9a + e7774c2
commit 3d7ea31
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/modules/app/src/main/scala/http.middleware.scala b/modules/app/src/main/scala/http.middleware.scala
@@ -14,7 +14,7 @@ def MkMiddleware(config: HttpServerConfig)(using LoggerFactory[IO]): Middleware
   def verboseLogger =
     RequestLogger.httpRoutes[IO](true, true).andThen(ResponseLogger.httpRoutes[IO, Request[IO]](true, true))
 
-  val logger =
+  def logger =
     if config.apiLogger then verboseLogger
     else ApiErrorLogger.instance(using LoggerFactory[IO].getLogger)
 

diff --git a/modules/app/src/main/scala/service.health.scala b/modules/app/src/main/scala/service.health.scala
@@ -8,14 +8,14 @@ import org.typelevel.log4cats.{ Logger, LoggerFactory }
 
 class HealthServiceImpl(esClient: ESClient[IO])(using LoggerFactory[IO]) extends HealthService[IO]:
 
-  given logger: Logger[IO] = LoggerFactory[IO].getLogger
+  given Logger[IO] = LoggerFactory[IO].getLogger
 
   override def healthCheck(): IO[HealthCheckOutput] =
     esClient.status
       .flatMap(transform)
       .map(HealthCheckOutput(_))
       .handleErrorWith: e =>
-        logger.error(e)("Error in health check") *>
+        Logger[IO].error(e)("Error in health check") *>
           IO.raiseError(InternalServerError(s"Internal server error $e"))
 
   private def transform(status: String): IO[ElasticStatus] =

diff --git a/modules/app/src/main/scala/service.search.scala b/modules/app/src/main/scala/service.search.scala
@@ -22,7 +22,7 @@ class SearchServiceImpl(esClient: ESClient[IO], metric: Histogram[IO, Double])(u
 
   import SearchServiceImpl.{ *, given }
 
-  given logger: Logger[IO] = LoggerFactory[IO].getLogger
+  private val logger: Logger[IO] = LoggerFactory[IO].getLogger
 
   private val baseAttributes = Attributes(Attribute("http.request.method", "POST"))
   private val countMetric =

diff --git a/smithy-build.json b/smithy-build.json
@@ -2,14 +2,14 @@
     "version": "1.0",
     "maven": {
         "dependencies": [
-            "com.disneystreaming.smithy4s:smithy4s-protocol:0.18.15",
+            "com.disneystreaming.smithy4s:smithy4s-protocol:0.18.27",
             "com.disneystreaming.alloy:alloy-core:0.3.4"
         ],
         "repositories": []
     },
     "imports": [
         "./src",
         "modules/smithy/src/main/smithy",
-        "modules/smithy/target/scala-3.5.0/src_managed/main/smithy"
+        "modules/smithy/target/scala-3.5.2/src_managed/main/smithy"
     ]
 }