Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require confirmation of global unicast addresses #2876

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

achingbrain
Copy link
Member

Some routers will allocate global unicast addresses which peers will treat as publicly routable. The routers may also firewall any incoming traffic to these addresses so require confirmation that the node is reachable before publishing such addresses.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Some routers will allocate global unicast addresses which peers
will treat as publicly routable.  The routers may also firewall
any incoming traffic to these addresses so require confirmation
that the node is reachable before publishing such addresses.
@achingbrain achingbrain requested a review from a team as a code owner December 6, 2024 11:13
@achingbrain achingbrain merged commit 92cc740 into main Dec 6, 2024
33 of 34 checks passed
@achingbrain achingbrain deleted the fix/require-confirmation-of-global-addresses branch December 6, 2024 11:32
@achingbrain achingbrain mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant