Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit observed addresses in address manager #2869

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

achingbrain
Copy link
Member

This is done in the identify protocol but the address manager should guard itself against misuse.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain achingbrain requested a review from a team as a code owner November 30, 2024 13:54
This is done in the identify protocol but the address manager
should guard itself against misuse.
@achingbrain achingbrain force-pushed the fix/limit-observed-addresses branch from 02de925 to 9a75560 Compare November 30, 2024 13:56
@achingbrain achingbrain merged commit 06f79b6 into main Nov 30, 2024
32 of 34 checks passed
@achingbrain achingbrain deleted the fix/limit-observed-addresses branch November 30, 2024 15:15
@achingbrain achingbrain mentioned this pull request Nov 30, 2024
acul71 pushed a commit to acul71/js-libp2p-fork that referenced this pull request Dec 1, 2024
This is done in the identify protocol but the address manager
should guard itself against misuse.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant