fix: ignore IPv6 link-local addresses #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Network interfaces generate their own link-local addresses when bootstrapping to the network. With IPv4 these are discarded when a DHCP server assigns an address but IPv6 interfaces keep them around. These aren't useful addresses after a routable address has been assigned so do not return them as addresses we are listening on.
achingbrain
changed the title
Merged
acul71
pushed a commit
to acul71/js-libp2p-fork
that referenced
this pull request
Dec 1, 2024
Network interfaces generate their own link-local addresses when bootstrapping to the network. With IPv4 these are discarded when a DHCP server assigns an address but IPv6 interfaces keep them around. These aren't useful addresses after a routable address has been assigned so do not return them as addresses we are listening on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network interfaces generate their own link-local addresses when bootstrapping to the network. With IPv4 these are discarded when a DHCP server assigns an address but IPv6 interfaces keep them around.
These aren't useful addresses after a routable address has been assigned so do not return them as addresses we are listening on.
Change checklist