fix: confirm dns mappings with ip mappings #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wildcard DNS servers let us map anything we think is a public ip address to a domain name, but ports stil need to be opened in firewalls so don't use the DNS mapping until an external port mapping has been configured.
Merged
acul71
pushed a commit
to acul71/js-libp2p-fork
that referenced
this pull request
Dec 1, 2024
Wildcard DNS servers let us map anything we think is a public ip address to a domain name, but ports stil need to be opened in firewalls so don't use the DNS mapping until an external port mapping has been configured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wildcard DNS servers let us map anything we think is a public ip address to a domain name, but ports stil need to be opened in firewalls so don't use the DNS mapping until an external port mapping has been configured.
Change checklist