Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove todo from auto tls #2844

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

achingbrain
Copy link
Member

The acme-client module takes care of retries after 429s so no need to handle it at this level.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

The `acme-client` module takes care of retries after 429s so no
need to handle it at this level.
@achingbrain achingbrain requested a review from a team as a code owner November 26, 2024 15:12
@achingbrain achingbrain merged commit 3650283 into main Nov 26, 2024
34 checks passed
@achingbrain achingbrain deleted the chore/remove-todo-from-auto-tls branch November 26, 2024 16:18
acul71 pushed a commit to acul71/js-libp2p-fork that referenced this pull request Dec 1, 2024
The `acme-client` module takes care of retries after 429s so no
need to handle it at this level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant