Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase WebRTC max datachannel message size #2627

Merged
merged 3 commits into from
Jul 22, 2024
Merged

fix: increase WebRTC max datachannel message size #2627

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d8a619
fix: increase WebRTC max datachannel message size
achingbrain Jul 18, 2024
161b2f5
chore: increase protobuf overhead as more bytes are needed to length …
achingbrain Jul 19, 2024
4b1179f
Merge branch 'main' into fix/increase-webrtc-max-message-size
achingbrain Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/transport-webrtc/src/stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,11 @@ export const VARINT_LENGTH = 2

/**
* Max message size that can be sent to the DataChannel
*
* @see https://blog.mozilla.org/webrtc/large-data-channel-messages/
* @see https://issues.webrtc.org/issues/40644524
*/
export const MAX_MESSAGE_SIZE = 16 * 1024
export const MAX_MESSAGE_SIZE = 256 * 1024

/**
* When closing streams we send a FIN then wait for the remote to
Expand Down
Loading