Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: limit default WebRTC STUN servers to 4x #2615

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix: limit default WebRTC STUN servers to 4x #2615

merged 1 commit into from
Jul 10, 2024

Conversation

achingbrain
Copy link
Member

Using 5x or more causes the following error to be printed in the console so only use 4x servers:

WebRTC: Using five or more STUN/TURN servers slows down discovery

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: limit default WebRTC STUN servers to 4x
becd80f 
Using 5x or more causes the following error to be printed in the
console so only use 4x servers:

```
WebRTC: Using five or more STUN/TURN servers slows down discovery
```
@achingbrain achingbrain requested a review from a team as a code owner July 10, 2024 17:00
@achingbrain achingbrain merged commit 3319ff4 into main Jul 10, 2024
24 checks passed
@achingbrain achingbrain deleted the fix/limit-stub-servers-to-four branch July 10, 2024 18:02
@achingbrain achingbrain mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @maschad