Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Transient connection logic judgment #2547

Closed
wants to merge 0 commits into from
Closed

fix: Transient connection logic judgment #2547

wants to merge 0 commits into from

Conversation

wlynxg
Copy link
Contributor

@wlynxg wlynxg commented May 15, 2024

Transient connection logic judgment

Description

In go-libp2p, transient connections are judged based on whether the relay node has restrictions on the current connection. Reference code: https://github.com/libp2p/go-libp2p/blob/fccfbe7a4b6841325100038b83f86cd4e097b9a1/p2p/protocol/circuitv2/client/dial.go#L181

This submission aligns js-libp2p logic with go-libp2p logic.

Notes & open questions

Change checklist

  • [ ✔ ] I have performed a self-review of my own code
  • [ ✔ ] I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • [ ✔ ] I have added tests that prove my fix is effective or that my feature works

@wlynxg wlynxg requested a review from a team as a code owner May 15, 2024 12:15
@achingbrain
Copy link
Member

Thanks for opening this. Please can you add a test to prevent future regressions and ensure linting passes.

@wlynxg
Copy link
Contributor Author

wlynxg commented May 17, 2024

Thanks for opening this. Please can you add a test to prevent future regressions and ensure linting passes.

Sorry, I'm not very familiar with js, I can't write this test😟

@dhuseby dhuseby added the help wanted Seeking public contribution on this issue label May 21, 2024
@maschad maschad removed the help wanted Seeking public contribution on this issue label May 21, 2024
@achingbrain achingbrain closed this Jun 6, 2024
@achingbrain
Copy link
Member

Hmm, not sure why that closed this PR. Continued in #2575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants