-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add private key to libp2p components #2303
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there a way we can do this in stages to prevent it causing libp2p v2? Perhaps just adding the private key in the first instance, then releasing it, then upgrading noise etc to use it? |
3 tasks
achingbrain
added a commit
that referenced
this pull request
Jan 16, 2024
- Add `privateKey` to `Components` - Non-breaking version of #2303 --------- Co-authored-by: Alex Potsides <[email protected]> Co-authored-by: chad <[email protected]>
Blocked waiting for the next breaking release |
27 tasks
Superseded by #2660 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
privateKey
toComponents
and use it where possibleprivateKey
instead ofpeerId
Change checklist
BREAKING CHANGE:
IdentifyComponents
now includes aprivateKey
PubSubComponents
now includes aprivateKey
CircuitRelayServerComponents
now includes aprivateKey
RecordEnvelope.seal
now has aprivateKey
as the second param rather than apeerId
RecordEnvelope
constructor now takes apublicKey