chore: fix pubsub interop tests #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When opening outbound streams, only make sure no outbound pubsub streams exist on the connection, not just any pubsub streams. Fixes a race condition where the remote peer can open streams before us which then prevents us opening streams.
achingbrain
force-pushed
the
chore/fix-interop-tests
branch
from
6d6f3a2 to
fc95a72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening outbound streams, only make sure no outbound pubsub streams exist on the connection, not just any pubsub streams.
Improves logging:
Fixes a race condition where the remote peer can open streams before us which then prevents us opening streams.
Change checklist