Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow dialing a peer when we only have transient connections #2187

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

achingbrain
Copy link
Member

If we dial a peer that we already have a connection to, we return that connection instead of dialing.

This creates a problem when we are trying to make a direct connection to a peer that we already have a relay connection to since the relay connection is returned.

The fix here is to allow additional dials to peers when we only have relay connections.

If a direct connection exists, we will still return it instead of dialing.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

If we dial a peer that we already have a connection to, we return that
connection instead of dialing.

This creates a problem when we are trying to make a direct connection
to a peer that we already have a relay connection to since the relay
connection is returned.

The fix here is to allow additional dials to peers when we only have
relay connections.

If a direct connection exists, we will still return it instead of dialing.
@achingbrain achingbrain requested a review from a team as a code owner November 1, 2023 18:37
@achingbrain achingbrain merged commit dd400cd into master Nov 2, 2023
20 of 22 checks passed
@achingbrain achingbrain deleted the fix/allow-dialing-non-transient-addresses branch November 2, 2023 14:44
This was referenced Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants