fix: allow dialing a peer when we only have transient connections #2187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we dial a peer that we already have a connection to, we return that connection instead of dialing.
This creates a problem when we are trying to make a direct connection to a peer that we already have a relay connection to since the relay connection is returned.
The fix here is to allow additional dials to peers when we only have relay connections.
If a direct connection exists, we will still return it instead of dialing.
Change checklist