fix: allow DHT self-query to time out #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we run our first self-query we first check the routing table to see if it has peers. If not we wait for some peers to be discovered before continuing. The change here is to use the general query AbortSignal to abort waiting for peers to be discovered. If they are not discovered allow other queries to continue and fail with eaiser to understand error messages. Also fixes some logging typos and makes error messages more understandable.
maschad
reviewed
Oct 24, 2023
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run our first self-query we first check the routing table to see if it has peers.
If not we wait for some peers to be discovered before continuing.
The change here is to use the general query AbortSignal to abort waiting for peers to be discovered. If they are not discovered allow other queries to continue and fail with eaiser to understand error messages.
Also fixes some logging typos and makes error messages more understandable.
Change checklist