Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_page_alloc #44

Closed
wants to merge 12 commits into from
Closed

use_page_alloc #44

wants to merge 12 commits into from

Conversation

jyizheng
Copy link

Make page_alloc.c and etc. compiled in the linux.so

Review on Reviewable

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 13c94a1 on jyizheng:nuse into 14929c5 on libos-nuse:nuse.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling abebc87 on jyizheng:nuse into 14929c5 on libos-nuse:nuse.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 05cd7d3 on jyizheng:nuse into 14929c5 on libos-nuse:nuse.

def_bool y

config INIT_DEBUG_ALWAYS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete it if this variable is not used anymore.
please review other variables too.

@thehajime
Copy link
Member

Yizheng,

I put comments for a couple of files and found your patches is not for the latest master.

now nuse branch is no longer the default and latest branch: please merge the latest master branch into your private branch, rebase it, and submit PR again.

thanks.

@jyizheng
Copy link
Author

Sure. I will try to sync with the latest code.
Thanks for all you comments.

Yizheng

On Sun, Jun 21, 2015 at 10:59 PM, Hajime Tazaki [email protected]
wrote:

Yizheng,

I put comments for a couple of files and found your patches is not for the
latest master.

now nuse branch is no longer the default and latest branch: please merge
the latest master branch into your private branch, rebase it, and submit PR
again.

thanks.


Reply to this email directly or view it on GitHub
#44 (comment)
.

@jyizheng
Copy link
Author

I really don't know how to make my repository synchronized
with the lastes code. Is it possible to help me out?

On Tue, Jun 23, 2015 at 1:03 PM, Andy Joe [email protected] wrote:

Sure. I will try to sync with the latest code.
Thanks for all you comments.

Yizheng

On Sun, Jun 21, 2015 at 10:59 PM, Hajime Tazaki [email protected]
wrote:

Yizheng,

I put comments for a couple of files and found your patches is not for
the latest master.

now nuse branch is no longer the default and latest branch: please merge
the latest master branch into your private branch, rebase it, and submit PR
again.

thanks.


Reply to this email directly or view it on GitHub
#44 (comment)
.

@thehajime
Copy link
Member

@jyizheng to synchronize your code to the master, 'git rebase' is the way for your pull request so that I can merge your patches on top of net-next-nuse tree (i.e., fast-forward merge).

for instance,

git checkout (your branch)
git rebase origin/master

@thehajime
Copy link
Member

@jyizheng I expect you cloud clean up PR #47 by git-rebase.

@jyizheng
Copy link
Author

OK. Let me try it.

On Wed, Aug 26, 2015 at 2:56 AM, Hajime Tazaki [email protected]
wrote:

@jyizheng https://github.com/jyizheng I expect you cloud clean up PR #47
#47 by git-rebase.


Reply to this email directly or view it on GitHub
#44 (comment)
.

@jyizheng
Copy link
Author

I don't know whether I have successfully merged my patches. Please check.
If it not, can we set up an online meeting some time to fix the problem?

@thehajime
Copy link
Member

@jyizheng hmm, I couldn't find your merged patches.
I will contact you privately for an online meeting.

jyizheng added a commit to jyizheng/net-next-nuse-old that referenced this pull request Sep 3, 2015
@jyizheng jyizheng closed this Sep 8, 2015
thehajime pushed a commit that referenced this pull request Oct 15, 2015
Push my initial work for uploading memory manager

add slib_env to use page_alloc.c

Add headers from arm/include/asm and try to initilize buddy system freelists

recover init/main.c

add WANT_PAGE_VIRTUAL to use page->virtual

a working version done

delete prink debug message

add a tiny change

try to make no impact on upstream kernel

solve OPT=no compiler crash

solve undefined symbol for init_mm

test

add build.sh

remove test

delete build.sh

add #endif

solve some unreferced symbol problem

change barrier.h

disable some compile time check for atomic variables

Do cleanup according to Hajime's suggestions.
Check here for details:
#44 (comment)

git rid of #if 0 useless code

Resolve Hajime'c commemts. Check here:
https://github.com/libos-nuse/net-next-nuse/pull/47/files#r38614406

add cache_is_vivt back to highmem.c again to resolve some warnings

resolve pull request comments

1)Change __MR_MAX_ZONES in arch/lib/Makefile
2)Use symbolic link in arch/lib/include
3)Resolve ERRORs reported by checkpatch.pl

Lib:
   1) resovle undefined symbol rumpns_irq_stat

disable compile time check

resolve pull request comments

add something missing in the last commit
thehajime pushed a commit that referenced this pull request Oct 23, 2015
Push my initial work for uploading memory manager

add slib_env to use page_alloc.c

Add headers from arm/include/asm and try to initilize buddy system freelists

recover init/main.c

add WANT_PAGE_VIRTUAL to use page->virtual

a working version done

delete prink debug message

add a tiny change

try to make no impact on upstream kernel

solve OPT=no compiler crash

solve undefined symbol for init_mm

test

add build.sh

remove test

delete build.sh

add #endif

solve some unreferced symbol problem

change barrier.h

disable some compile time check for atomic variables

Do cleanup according to Hajime's suggestions.
Check here for details:
#44 (comment)

git rid of #if 0 useless code

Resolve Hajime'c commemts. Check here:
https://github.com/libos-nuse/net-next-nuse/pull/47/files#r38614406

add cache_is_vivt back to highmem.c again to resolve some warnings

resolve pull request comments

1)Change __MR_MAX_ZONES in arch/lib/Makefile
2)Use symbolic link in arch/lib/include
3)Resolve ERRORs reported by checkpatch.pl

Lib:
   1) resovle undefined symbol rumpns_irq_stat

disable compile time check

resolve pull request comments

add something missing in the last commit
thehajime pushed a commit that referenced this pull request Nov 9, 2015
Push my initial work for uploading memory manager

add slib_env to use page_alloc.c

Add headers from arm/include/asm and try to initilize buddy system freelists

recover init/main.c

add WANT_PAGE_VIRTUAL to use page->virtual

a working version done

delete prink debug message

add a tiny change

try to make no impact on upstream kernel

solve OPT=no compiler crash

solve undefined symbol for init_mm

test

add build.sh

remove test

delete build.sh

add #endif

solve some unreferced symbol problem

change barrier.h

disable some compile time check for atomic variables

Do cleanup according to Hajime's suggestions.
Check here for details:
#44 (comment)

git rid of #if 0 useless code

Resolve Hajime'c commemts. Check here:
https://github.com/libos-nuse/net-next-nuse/pull/47/files#r38614406

add cache_is_vivt back to highmem.c again to resolve some warnings

resolve pull request comments

1)Change __MR_MAX_ZONES in arch/lib/Makefile
2)Use symbolic link in arch/lib/include
3)Resolve ERRORs reported by checkpatch.pl

Lib:
   1) resovle undefined symbol rumpns_irq_stat

disable compile time check

resolve pull request comments

add something missing in the last commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants