Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract function "copy_plist_item" #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stefanbirkner
Copy link

@stefanbirkner stefanbirkner commented Nov 16, 2019

Improve readability of the function "update_client_info". It is now easier to see that it copies four items with the same algorithm.

@stefanbirkner stefanbirkner force-pushed the extract-copy-plist-item branch from 8e8f5ed to 0ebce9c Compare December 20, 2019 20:19
@stefanbirkner stefanbirkner force-pushed the extract-copy-plist-item branch 3 times, most recently from 2b55bbc to 0ee3806 Compare June 14, 2020 16:46
Improve readability of the function "update_client_info". It is now
easier to see that it copies four items with the same algorithm.
@stefanbirkner stefanbirkner force-pushed the extract-copy-plist-item branch from 0ee3806 to baf4731 Compare September 13, 2020 00:17
Copy link

@yassineboubaker yassineboubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants