Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make titles of the docstrings more useful (plus cleanup) #47

Merged
merged 3 commits into from
Aug 13, 2020

Conversation

mhvk
Copy link
Contributor

@mhvk mhvk commented Aug 13, 2020

The discussion in liberfa/erfa#24 made me realize that the current docstrings for the python functions are less than helpful, having as title just "Wrapper for ...", which tells one very little. So, I changed the generator such that it uses the first sentence of the description instead. The summary in particular is more descriptive (see below).

As I was a bit irritated in seeing red wiggles while editing various files, I also made everything PEP8 compliant (with slightly longer lines). Finally, in the C code a few mentions of astropy were still present, so I took the opportunity to change those. Those may make review a bit more messy; it may make most sense to look by commit...

image

@mhvk mhvk added the documentation Improvements or additions to documentation label Aug 13, 2020
@mhvk mhvk requested a review from avalentino August 13, 2020 00:30
@avalentino avalentino merged commit 5e648a4 into liberfa:master Aug 13, 2020
@mhvk mhvk deleted the docstring-titles branch August 13, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants