mantle/wsi: fix minImageCount #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamahuman
reviewed
Dec 20, 2023
| // Recreate swapchain | ||
| const VkSwapchainCreateInfoKHR swapchainCreateInfo = { | ||
| .sType = VK_STRUCTURE_TYPE_SWAPCHAIN_CREATE_INFO_KHR, | ||
| .pNext = NULL, | ||
| .flags = 0, | ||
| .surface = mSurface, | ||
| .minImageCount = 3, | ||
| .minImageCount = MAX(3, surfaceCapabilities.minImageCount), |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
according to the spec maxImageCount may be 0, and then we would need additional logic to account for that, I think minImage is better
There was a problem hiding this comment.
Ok. Thanks for the heads-up!
Perhaps your original patch was right, then?
Suggested change
| .minImageCount = MAX(3, surfaceCapabilities.minImageCount), | |
| .minImageCount = MAX(2, surfaceCapabilities.minImageCount), |
There was a problem hiding this comment.
I don't think 2 vs 3 images is gonna make a big difference, but I might be wrong on that
There was a problem hiding this comment.
We can just do: .minImageCount = surfaceCapabilities.minImageCount
There was a problem hiding this comment.
sometimes the minImageCount can be 1 and idk if apps will like that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix grvk on winewayland