Skip to content

Commit

Permalink
Merge pull request MarkEdmondson1234#205 from ramnathv/master
Browse files Browse the repository at this point in the history
feat: allow availableSecrets and build_args
  • Loading branch information
MarkEdmondson1234 authored Jan 24, 2023
2 parents a435d80 + 7d863d9 commit 0a977af
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions R/docker.R
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ cr_deploy_docker <- function(local,
predefinedAcl = "bucketOwnerFullControl",
pre_steps = NULL,
post_steps = NULL,
availableSecrets = NULL,
...) {
result <- cr_deploy_docker_construct(
local = local,
Expand All @@ -133,6 +134,7 @@ cr_deploy_docker <- function(local,
predefinedAcl = predefinedAcl,
pre_steps = pre_steps,
post_steps = post_steps,
availableSecrets = availableSecrets,
...
)

Expand Down Expand Up @@ -180,8 +182,8 @@ cr_deploy_docker_construct <- function(
predefinedAcl = "bucketOwnerFullControl",
pre_steps = NULL,
post_steps = NULL,
availableSecrets = NULL,
...) {

assert_that(
dir.exists(local)
)
Expand Down Expand Up @@ -237,7 +239,8 @@ cr_deploy_docker_construct <- function(
)
build_yaml <- cr_build_yaml(
steps = steps,
images = pushed_image
images = pushed_image,
availableSecrets = availableSecrets
)

list(
Expand Down Expand Up @@ -402,6 +405,7 @@ cr_buildstep_docker <- function(
"-f", dockerfile,
"--destination", paste0(the_image, ":", x),
sprintf("--context=%s", build_context),
build_args,
"--cache=true"
),
...
Expand Down

0 comments on commit 0a977af

Please sign in to comment.