Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for multiple verifiers, use the most recent #28

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

Th0rgal
Copy link
Member

@Th0rgal Th0rgal commented Oct 11, 2023

This pull request adds support for multiple social verifiers, when multiple values are conflicting, it will take the most recent one. This allows us to update the social verifier to a new implementation (hopefully upgradable this one) without needing users to reverify.

I added a sort in the aggregate to get results from the oldest to the new one and the algorithm will loop around them and override the values until the end.

@Th0rgal Th0rgal requested a review from irisdv October 11, 2023 07:46
@Th0rgal Th0rgal self-assigned this Oct 11, 2023
@Th0rgal Th0rgal added the 🔥 Ready for review This pull request needs a review label Oct 11, 2023
Copy link
Collaborator

@irisdv irisdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@irisdv irisdv merged commit 877f4fb into master Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Ready for review This pull request needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants