Set volumeStatus.FileLocation to PVC name for kubevirt eve #4497
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VolumeStatus of FileLocation may not be set for volumes in kubevirt eve since they are PVCs. They will not have a explicit path under /persist/. Set the filelocation to PVC name. Which will be used by the volumehandler to get volume details. This will fix the app disk metrics. Signed-off-by: Pramodh Pallapothu <[email protected]>
zedi-pramodh
requested review from
OhmSpectator,
deitch and
rouming
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VolumeStatus of FileLocation may not be set for volumes in kubevirt eve since they are PVCs. They will not have a explicit path under /persist/. Set the filelocation to PVC name. Which will be used by the volumehandler to get volume details.
This will fix the app disk metrics.