Ignore /persist/kube-save-var-lib directory #4496
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We save the backup of k3s installation to /persist to switch from clustering to single node. Exclude this directory from diskmetrics collection. This leads to 200+ json files which are processed unneccesarily, also the space occupied is already accounted in /persist Signed-off-by: Pramodh Pallapothu <[email protected]>
OhmSpectator
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
As as an atomic change, looks fine.
But wouldn't we need also to include the directory to the list of the directories handled on the device boot here or somewhere in this script?
No we cannot delete this directory, it's a backup/snapshot of the single node installation and we need that to rollback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We save the backup of k3s installation to /persist to switch from clustering to single node. Exclude this directory from diskmetrics collection. This leads to 200+ json files which are processed unneccesarily, also the space occupied is already accounted in /persist