[12.0-stable] Only check IsPort for iobundle types which are Net #4483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip over HDMI, COM. IsPort only checks Ifname which can incorrectly flag non-net devices as a port. Signed-off-by: Andrew Durbin <[email protected]> (cherry picked from commit 7311ddf)
andrewd-zededa
requested review from
OhmSpectator and
milan-zededa
as code owners
github-actions
bot
requested review from
eriknordmark,
jsfakian and
uncleDecart
|
Do we have to back port it to other LTS? (13.4) |
|
@OhmSpectator most likely, is 13.4 the only other lts/stable? |
|
While we are preparing the 13.4-LTS release, we have to backport to:
|
OhmSpectator
approved these changes
Dec 13, 2024
OhmSpectator
changed the title
OhmSpectator
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4482
Skip over HDMI, COM. IsPort only checks Ifname which can incorrectly flag non-net devices as a port.
Signed-off-by: Andrew Durbin [email protected]
(cherry picked from commit 7311ddf)