agentlog: fix race condition in tests #4471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output of the race condition detector was:
=== FAIL: agentlog TestPsiEveIntegratedStartTwice (0.17s)
==================
WARNING: DATA RACE
Write at 0x0000029a6120 by goroutine 80:
github.com/lf-edge/eve/pkg/pillar/agentlog_test.emulateMemoryPressureStats()
/pillar/agentlog/agentlog_test.go:301 +0xd1
github.com/lf-edge/eve/pkg/pillar/agentlog_test.preparePSIEnvironment()
/pillar/agentlog/agentlog_test.go:455 +0x85
github.com/lf-edge/eve/pkg/pillar/agentlog_test.TestPsiEveIntegratedStartTwice()
/pillar/agentlog/agentlog_test.go:616 +0x44
testing.tRunner()
/usr/lib/go/src/testing/testing.go:1576 +0x216
testing.(*T).Run.func1()
/usr/lib/go/src/testing/testing.go:1629 +0x47
Previous read at 0x0000029a6120 by goroutine 78:
github.com/lf-edge/eve/pkg/pillar/agentlog.collectMemoryPSI()
/pillar/agentlog/memprofile.go:151 +0x116
github.com/lf-edge/eve/pkg/pillar/agentlog.MemoryPSICollector()
/pillar/agentlog/memprofile.go:248 +0x810
github.com/lf-edge/eve/pkg/pillar/agentlog.ListenDebug.func6.1()
/pillar/agentlog/http-debug.go:474 +0x7e
Goroutine 80 (running) created at:
testing.(*T).Run()
/usr/lib/go/src/testing/testing.go:1629 +0x805
testing.runTests.func1()
/usr/lib/go/src/testing/testing.go:2036 +0x8d
testing.tRunner()
/usr/lib/go/src/testing/testing.go:1576 +0x216
testing.runTests()
/usr/lib/go/src/testing/testing.go:2034 +0x87c
testing.(*M).Run()
/usr/lib/go/src/testing/testing.go:1906 +0xb44
main.main()
_testmain.go:102 +0x2fc
Goroutine 78 (running) created at:
github.com/lf-edge/eve/pkg/pillar/agentlog.ListenDebug.func6()
/pillar/agentlog/http-debug.go:473 +0x2ce
net/http.HandlerFunc.ServeHTTP()
/usr/lib/go/src/net/http/server.go:2122 +0x4d
net/http.(*ServeMux).ServeHTTP()
/usr/lib/go/src/net/http/server.go:2500 +0xc5
net/http.serverHandler.ServeHTTP()
/usr/lib/go/src/net/http/server.go:2936 +0x682
net/http.(*conn).serve()
/usr/lib/go/src/net/http/server.go:1995 +0xbd4
net/http.(*Server).Serve.func3()
/usr/lib/go/src/net/http/server.go:3089 +0x58
==================
testing.go:1446: race detected during execution of test
Signed-off-by: Christoph Ostarek <[email protected]>
|
Re-running failed Eden tests... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output of the race condition detector was: