[13.4 stable] Add missing nil check for DPC when processing wwan status update #4463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DPC can be still nil when DPCManager receives the first status from the wwan microservice. Without nil check, processWwanStatus function may therefore hit the nil dereference panic. Another small change in this commit is to avoid redundant calls to currentDPC() - dpc is already retrieved at the beginning of the function. Signed-off-by: Milan Lenco <[email protected]> (cherry picked from commit a984bcb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DPC can be still nil when
DPCManagerreceives the first status from the wwan microservice. Without nil check,processWwanStatusfunction may therefore hit the nil dereference panic.Another small change in this commit is to avoid redundant calls to
currentDPC()- dpc is already retrieved at the beginning of the function.Signed-off-by: Milan Lenco [email protected]
(cherry picked from commit a984bcb)