-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial raspberrypi5 support #4441
Conversation
- enable booting from sd card - u-boot has no pci support for rpi5 yet, so the usb/ethernet ports are not enabled. - there is no hdmi output yet, only uart. Signed-off-by: Dimitrios Poulios <[email protected]>
- enable raspberrypi5 console in grub config - use the devicetree provided by the firmware (and not the one provided by the kernel) to ensure the ethernet mac address is set correctly Signed-off-by: Dimitrios Poulios <[email protected]>
pkg/u-boot/Dockerfile
Outdated
@@ -8,7 +8,9 @@ SHELL ["/bin/bash", "-eo", "pipefail", "-c"] | |||
ENV VERSION v2024.10-rc2 | |||
ENV SOURCE_URL https://github.com/u-boot/u-boot/archive/${VERSION}.tar.gz | |||
ENV RASPBERRY_FIRMWARE_BLOBS_VERSION 1.20211007 | |||
ENV RASPBERRY_FIRMWARE_BLOBS_VERSION2 1.20240306 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use some more descriptive names, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, it would be better to get all the files from the newer version, but then I guess we should test on all raspberry devices to ensure that everything is ok.
pkg/u-boot/Dockerfile
Outdated
@@ -8,7 +8,9 @@ SHELL ["/bin/bash", "-eo", "pipefail", "-c"] | |||
ENV VERSION v2024.10-rc2 | |||
ENV SOURCE_URL https://github.com/u-boot/u-boot/archive/${VERSION}.tar.gz | |||
ENV RASPBERRY_FIRMWARE_BLOBS_VERSION 1.20211007 | |||
ENV RASPBERRY_FIRMWARE_BLOBS_VERSION2 1.20240306 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dpoulios I think we can use the newest firmware for RPi model 4 as well, right? So you can just update the version on RASPBERRY_FIRMWARE_BLOBS_VERSION...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will do it this way and test on rpi4 & rpi5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested on RPI4, RPI5 & OnLogic FR201 (rpi cm4) using the latest firmware files (version 1.20240306 for all binary files we download) and although rpi4 & rpi5 seemed ok, I saw some issues in u-boot in FR201. So, I'm suggesting to keep this as it is now (that is to use only the rpi5 devicetree from the latest version and the other files from the original version) and revisit it again in the future.
- Latest u-boot has removed smbios model info for raspberrypi devices - So, grub gets the full product name reported by the firmware (eg. "Raspberry Pi 4 Model B Rev 1.5" / "Raspberry Pi 5 Model B Rev 1.0") - We use regexp to be able to support different revisions of the devices Signed-off-by: Dimitrios Poulios <[email protected]>
During the latest tests I did, I discovered that in this u-boot version (we updated it in the FR201 pr), the smbios model info for raspberrypi devices has been removed. So, now when grub asks for the smbios model name it gets a string like "Raspberry Pi 4 Model B Rev 1.5", instead of "rpi" that it was returned with the old u-boot version. Therefore, I updated this for rpi4 & rpi5 in the latest commit I pushed. In order to support different revisions of the devices, the "regexp" command of grub was used, to ignore the revision part in the string. |
pkg/u-boot/Dockerfile
Outdated
ENV RASPBERRY_FIRMWARE_BLOBS https://github.com/raspberrypi/firmware/raw/${RASPBERRY_FIRMWARE_BLOBS_VERSION} | ||
ENV RASPBERRY_FIRMWARE_BLOBS2 https://github.com/raspberrypi/firmware/raw/${RASPBERRY_FIRMWARE_BLOBS_VERSION2} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, are we going to fix the variable names?...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: RASPBERRY_5_FIRMWARE_BLOBS
, RASPBERRY_FIRMWARE_BLOBS_RPI5
or something like that....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR still looks to be in a PoC form. I hope it becomes pretty soon =)
Use better variable names for rpi5 firmware files Signed-off-by: Dimitrios Poulios <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If @rene is fine, let's start the tests...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Initial support for rpi5: