-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocking kube container logs to be sent and some minor changes #4412
Blocking kube container logs to be sent and some minor changes #4412
Conversation
naiming-zededa
commented
Oct 31, 2024
- Not sending kube container side of logs, if needed, use collect-info to get the info or logs.
- kube log directory has changed, adjust various component logging to that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to introduce a new /persist/kubelog directory we need to teach all parts of pillar about it (zedagent reports size of directories, onboot ensures there is sufficient space to boot EVE, etc).
Also, do we already manage the size of the existing /persist/newlog/kube using the limit for /persist/newlog? If so, to what value and what code will manage the space for /persist/kubelog?
3c67a0b
to
af4e5e5
Compare
Yeh, missed that. add to the patch for the /persist/kubelog in the 'ReportDirPaths'
This is handled in the cluster-init.sh
we rotate them and keep 3 copies with 5M max to each of them. |
Why are we moving it from |
we first put them inside the 'persist/newlog', since those kubernetes logs does not follow the newlog pattern, and if we want to use 'edgeview' to get the last 15 minutes log, it will get also tons of kuberntes logs. it breaks the way we can precisely getting the time range of newlogs. so we moved it out. |
I didn't understand why it does, but it doesn't matter. If you are saying that it breaks it, and we need to move them, good enough. Thanks for explaining. |
af4e5e5
to
efbfc7a
Compare
Also added /persist/kubelog to 'collect-info.sh' |
There is also code in pkg/pillar/scripts/onboot.sh with PERSIST_CLEANUPS being a prioritized list of where to cleanup to make sure there is sufficient space for the system containerd (hence pillar, newlogd, etc) being able to start. |
- Not sending kube container side of logs, if needed, use collect-info to get the info or logs. - kube log directory has changed, adjust various component logging to that Signed-off-by: Naiming Shen <[email protected]>
efbfc7a
to
b13594b
Compare
Got it. updated on this file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM