update: switch assets.yml to use GitHub API for artifact upload

[yash-zededa]

Previous action for uploading artifacts to GitHub Releases failed due to parallel (matrix) execution issues. Replaced it with direct GitHub API calls to handle uploads.

This change provides more flexibility and control over artifact management and release handling.

[deitch]

Since you already converted all of the assets to ARCH.*, can you not just do for file in assets/*?

[deitch]

Come to think of it, why even bother with the step "Rename files for release" and then this step? Just combine them:

for file in assets/*; do
    file_name=${{ env.ARCH }}.$(basename "$file")
    echo "Uploading $file as $file_name..."
    # do upload
done

[yash-zededa]

Good suggestion! We can combine them, but since assets/${{ env.ARCH }}.rootfs.img.sha256 isn't part of the assets, I’ll just need to generate the sha256sum and make the necessary modifications.

[yash-zededa]

@deitch combined the two loops and added a condition for the sha256 checksum for rootfs.img

[eriknordmark]

Do the parallel runs in the matrix share their assets? If so the loop might pick up the assets from another run which isn't done yet.

[yash-zededa]

Nope, the parallel runs don't share the assets.

[eriknordmark]

ok

[deitch]

Is there any reason to make this the only file that already has the ${ARCH} at the beginning, and then you need the extra logic below? Can you do it more simply?

          sha256sum "assets/rootfs.img" | awk '{ print $1 }' > "assets/rootfs.img.sha256"
          for asset in assets/*; do
              base_name=$(basename "$asset")
              new_name="${ARCH}.${base_name}"  # Add ARCH prefix
              echo "Uploading $asset as $new_name..."
            upload_response=$(curl -s -X POST \
              -H "Authorization: Bearer $GITHUB_TOKEN" \
              -H "Content-Type: application/octet-stream" \
              --data-binary @"$asset" \
              "$UPLOAD_URL?name=$new_name")
    done

[yash-zededa]

From what I understand, the assets/${ARCH}.rootfs.img.sha256 file is generated by the GitHub Actions workflow. If I create this file inside the loop, the loop may miss it and it won’t be uploaded. Therefore, I need to generate the checksum file first and include an if condition in the loop to ensure it doesn’t get renamed again.

I hope my understanding is correct and that I'm not going into loops.

[deitch]

You aren't doing it inside the loop, but just before the loop. This is all part of a single script, so you should be fine.

[yash-zededa]

Oh, I missed the last part. Yes, we can simplify this by creating a new file and letting the loop handle it.

I'm not sure why I didn't consider that and why I'm making things more complicated than necessary :)

[yash-zededa]

Fixed.

[deitch]

I'm not sure why I didn't consider that and why I'm making things more complicated than necessary :)

human + engineer = make things complicated

just the way we are wired. 😄

[eriknordmark]

Once the review is done, can you make this PR be on top of 13.6? That way we can create a 13.6.1 and later delete it (if everything works) and put this in master and in 13.4-stable.