Add support for OnLogic FR201 device #4382

dpoulios · 2024-10-18T14:51:34Z

No description provided.

codecov · 2024-10-18T15:36:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.93%. Comparing base (d1e13b8) to head (a1972fc).
Report is 112 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4382      +/-   ##
==========================================
- Coverage   21.05%   20.93%   -0.13%     
==========================================
  Files          13       13              
  Lines        2878     2895      +17     
==========================================
  Hits          606      606              
- Misses       2146     2163      +17     
  Partials      126      126

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rene

@dpoulios, left some comments, the WIP commit must be addressed....

README.md

pkg/dom0-ztools/rootfs/etc/init.d/000-mod-params

README.md

kernel-commits.mk

rene · 2024-10-18T16:32:57Z

pkg/u-boot/Dockerfile

@@ -1,11 +1,11 @@
-FROM lfedge/eve-alpine:591df01e581889c3027514c8a91feaca1c8ad49f AS build-base
-ENV BUILD_PKGS bash binutils-dev build-base bc bison flex openssl-dev python3 swig dtc
+FROM lfedge/eve-alpine:591df01e581889c3027514c8a91feaca1c8ad49f as build-base


You don't need this change AS -> as

pkg/u-boot/patches/patches-v2024.10-rc2/0002-0007-tweak-uefi-dt-selection.patch.patch

pkg/u-boot/Dockerfile

pkg/u-boot/patches/patches-v2024.10-rc2/0003-Add-XHCI_BRCM.patch

eriknordmark · 2024-10-23T12:42:39Z

@rene is part of this in #4395 ?

rene · 2024-10-24T09:49:18Z

@rene is part of this in #4395 ?

Only the kernel update commit @eriknordmark , so @dpoulios doesn't need to include the kernel hash update here...

Add support to OnLogic FR201 device, based on the Raspberry Pi 4 Compute Module (CM4): - Migrate to u-boot v2024.10-rc2 - Provide device tree overlay for the TPM chip - Provide SMBIOS information for the device - Provide custom boot parameters for the device Signed-off-by: Renê de Souza Pinto <[email protected]>

If the OnLogic FR201 device is detected, load the corresponding device tree. Also, set ttyS0 and tty0 as the default consoles, eMMC as default installer device and NVMe (sdb) as the default persist device. Signed-off-by: Renê de Souza Pinto <[email protected]>

- Enables USB2 ports of FR201 in u-boot (and consequently in grub) using the XHCI USB controller (with XHCI_BRCM device driver) - Removes unneeded support for the old DWC2 USB controller Signed-off-by: Dimitrios Poulios <[email protected]>

eve-kernel creates a dedicated device tree for OnLogic's FR201, based on RaspberryPi CM4 device tree (commit: bad2b4454467) Signed-off-by: Dimitrios Poulios <[email protected]>

Cleanup u-boot dockerfile and patches for the old and new version (v2024.10-rc2) Signed-off-by: Dimitrios Poulios <[email protected]>

README.md

rene

I have just one small comment, will approve to trigger the tests...

eriknordmark · 2024-10-26T21:26:39Z

The riscv build failed in https://github.com/lf-edge/eve/actions/runs/11522045471?pr=4382

README update on how to use EVE on the OnLogic FR201 device Signed-off-by: Dimitrios Poulios <[email protected]>

This commit updates the kernel version for arm64 on branches 6.1.106 & 6.1.112 to enable support for the rtc device on OnLogic FR201 board. eve-kernel-arm64-v6.1.106-generic 3d5519df04f1: arm64: make rtc_pcf85063 driver builtin eve-kernel-arm64-v6.1.112-generic 4f8bebb80835: arm64: make rtc_pcf85063 driver builtin Signed-off-by: Dimitrios Poulios <[email protected]>

dpoulios · 2024-11-01T08:50:54Z

The riscv build failed in https://github.com/lf-edge/eve/actions/runs/11522045471?pr=4382

The riscv64 build fails because the package gnutls-dev (needed to build the updated u-boot) is not available in alpine 3.16 for risc.
It becomes available in 3.20. Should we update alpine?

OhmSpectator

It becomes available in 3.20. Should we update alpine?

Can't we work around it for now? We can update Alpine to 3.20, but it can bring some other issues in other packages; that would be nice to resolve in a dedicated PR, I would say.

So, we

either postpone this PR merge until we do the Alpine upgrade to 3.20 in a dedicated PR
or introduce a workaround here for 3.16 and do the upgrade later

Our option depends on how urgent we expect the OnLogic device support.

dpoulios · 2024-11-04T14:01:09Z

It becomes available in 3.20. Should we update alpine?

Can't we work around it for now? We can update Alpine to 3.20, but it can bring some other issues in other packages; that would be nice to resolve in a dedicated PR, I would say.

So, we
* either postpone this PR merge until we do the Alpine upgrade to 3.20 in a dedicated PR

* or introduce a workaround here for 3.16 and do the upgrade later
Our option depends on how urgent we expect the OnLogic device support.

Ok, I was able to build it without the gnutls_dev package. This is needed just to build the mkeficapsule tool of u-boot. So, we can safely disable it.

I will upload a patch shortly.

rene · 2024-11-04T14:16:51Z

It becomes available in 3.20. Should we update alpine?

Can't we work around it for now? We can update Alpine to 3.20, but it can bring some other issues in other packages; that would be nice to resolve in a dedicated PR, I would say.
So, we
* either postpone this PR merge until we do the Alpine upgrade to 3.20 in a dedicated PR

* or introduce a workaround here for 3.16 and do the upgrade later
Our option depends on how urgent we expect the OnLogic device support.
Ok, I was able to build it without the gnutls_dev package. This is needed just to build the mkeficapsule tool of u-boot. So, we can safely disable it.

I will upload a patch shortly.

Thank you @dpoulios , that's perfect...

pkg/u-boot/patches/patches-v2024.10-rc2/0004-Disable-mkeficapsule-tool.patch

Don't build mkeficapsule tool in u-boot to fix riscv64 build. The latest u-boot requires gnutls-dev package which is not available in alpine 3.16 for riscv64 (alpine 3.20 is needed). Signed-off-by: Dimitrios Poulios <[email protected]>

rene

LGTM, let's trigger tests....

pkg/u-boot/patches/patches-v2024.10-rc2/0003-Add-XHCI_BRCM.patch

pkg/u-boot/rpi/config.txt

rene

Triggering tests....

dpoulios requested review from rene, rouming and eriknordmark as code owners October 18, 2024 14:51

github-actions bot requested review from christoph-zededa and rucoder October 18, 2024 14:52

rene requested changes Oct 18, 2024

View reviewed changes

rene reviewed Oct 18, 2024

View reviewed changes

pkg/u-boot/patches/patches-v2024.10-rc2/0003-Add-XHCI_BRCM.patch Show resolved Hide resolved

rene and others added 5 commits October 25, 2024 17:09

grub: Use dedicated device tree for OnLogic FR201 device on linux

a8292a7

eve-kernel creates a dedicated device tree for OnLogic's FR201, based on RaspberryPi CM4 device tree (commit: bad2b4454467) Signed-off-by: Dimitrios Poulios <[email protected]>

u-boot: cleanup patches & dockerfile

040799e

Cleanup u-boot dockerfile and patches for the old and new version (v2024.10-rc2) Signed-off-by: Dimitrios Poulios <[email protected]>

dpoulios force-pushed the onlogic-fr201 branch from a1972fc to 0bf74d6 Compare October 25, 2024 14:45

github-actions bot requested a review from rene October 25, 2024 14:46

rene reviewed Oct 25, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

rene approved these changes Oct 25, 2024

View reviewed changes

dpoulios force-pushed the onlogic-fr201 branch from 0bf74d6 to fdf2a73 Compare October 25, 2024 16:36

github-actions bot requested a review from rene October 25, 2024 16:37

docs: Add support information for OnLogic FR201 device

538e911

README update on how to use EVE on the OnLogic FR201 device Signed-off-by: Dimitrios Poulios <[email protected]>

dpoulios force-pushed the onlogic-fr201 branch from fdf2a73 to d40de7a Compare October 31, 2024 16:16

OhmSpectator reviewed Nov 4, 2024

View reviewed changes

rene reviewed Nov 4, 2024

View reviewed changes

pkg/u-boot/patches/patches-v2024.10-rc2/0004-Disable-mkeficapsule-tool.patch Outdated Show resolved Hide resolved

pkg/u-boot: fix riscv64 build

e7106fe

Don't build mkeficapsule tool in u-boot to fix riscv64 build. The latest u-boot requires gnutls-dev package which is not available in alpine 3.16 for riscv64 (alpine 3.20 is needed). Signed-off-by: Dimitrios Poulios <[email protected]>

dpoulios force-pushed the onlogic-fr201 branch from c075ca1 to e7106fe Compare November 4, 2024 17:43

github-actions bot requested a review from rene November 4, 2024 17:44

rene approved these changes Nov 5, 2024

View reviewed changes

eriknordmark reviewed Nov 5, 2024

View reviewed changes

pkg/u-boot/patches/patches-v2024.10-rc2/0003-Add-XHCI_BRCM.patch Show resolved Hide resolved

eriknordmark reviewed Nov 5, 2024

View reviewed changes

pkg/u-boot/rpi/config.txt Show resolved Hide resolved

eriknordmark reviewed Nov 5, 2024

View reviewed changes

pkg/u-boot/rpi/config.txt Show resolved Hide resolved

rene approved these changes Nov 6, 2024

View reviewed changes

eriknordmark merged commit 8e60e96 into lf-edge:master Nov 6, 2024
65 of 95 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for OnLogic FR201 device #4382

Add support for OnLogic FR201 device #4382

dpoulios commented Oct 18, 2024

codecov bot commented Oct 18, 2024

rene left a comment

rene Oct 18, 2024

eriknordmark commented Oct 23, 2024

rene commented Oct 24, 2024

rene left a comment

eriknordmark commented Oct 26, 2024

dpoulios commented Nov 1, 2024

OhmSpectator left a comment

dpoulios commented Nov 4, 2024

rene commented Nov 4, 2024

rene left a comment

rene left a comment

Add support for OnLogic FR201 device #4382

Add support for OnLogic FR201 device #4382

Conversation

dpoulios commented Oct 18, 2024

codecov bot commented Oct 18, 2024

Codecov Report

rene left a comment

Choose a reason for hiding this comment

rene Oct 18, 2024

Choose a reason for hiding this comment

eriknordmark commented Oct 23, 2024

rene commented Oct 24, 2024

rene left a comment

Choose a reason for hiding this comment

eriknordmark commented Oct 26, 2024

dpoulios commented Nov 1, 2024

OhmSpectator left a comment

Choose a reason for hiding this comment

dpoulios commented Nov 4, 2024

rene commented Nov 4, 2024

rene left a comment

Choose a reason for hiding this comment

rene left a comment

Choose a reason for hiding this comment