Wait for 15 seconds for the qmp listener #4330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriknordmark
requested review from
OhmSpectator,
rene and
rouming
as code owners
rene
reviewed
Oct 10, 2024
eriknordmark
force-pushed
the
fetchcerts
branch
from
c44d2b4 to
67e7404
Compare
Would need to have a way to stub out the go-qemu/qmp package to do delay and fault injection in order to do unit tests for this. That would require some refactoring which doesn't make sense now given that this is a regression in 13.4 |
For sure we can add them later |
eriknordmark
force-pushed
the
fetchcerts
branch
from
67e7404 to
59ad67c
Compare
eriknordmark
force-pushed
the
fetchcerts
branch
from
59ad67c to
61b40c8
Compare
eriknordmark
force-pushed
the
fetchcerts
branch
from
61b40c8 to
d75c7e7
Compare
Make the code consitently wait/retry for 15 seconds - in some cases it would only wait for 3 seconds. Fixes timeout on slow devices. Signed-off-by: eriknordmark <[email protected]>
eriknordmark
force-pushed
the
fetchcerts
branch
from
d75c7e7 to
20714e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the code consitently wait/retry for 15 seconds - in some cases it would only wait for 3 seconds. Fixes timeout on slow devices. Those timeouts seem to have started to appear with the new xentools version, so marking this as stable.