-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: eden.yml to refer to the correct output for run_id #4195
Conversation
Updated the trigger_pr job to use the correct output for the run id. This is required for eden to download the artefacts. Signed-off-by: yash-zededa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to test it?
=( |
We don't and can't run the workflows when the workflow files change. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4195 +/- ##
=======================================
Coverage 19.69% 19.69%
=======================================
Files 8 8
Lines 2600 2600
=======================================
Hits 512 512
Misses 1985 1985
Partials 103 103 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try it
@OhmSpectator Not easily, I would say :). For The error is expected and can be ignored. For GHA to pick up changes in eden.yml, they need to be merged into the base branch. The eden.yml file is just there to trigger the test with the eden version. I can see the run_id in output now so should be fixed. |
According to the GitHub documentation, there is an option to run workflows from a forked repository, but this depends on the settings at the organization level. I assume that workflows from forked repositories should not be executed, which seems prudent. |
I've updated the
test_suite_pr
job to use the correct output for the run ID, which Eden needs to download the artifacts.