dpcreconciler: set MAC and interface rename while interface is DOWN #4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4193 +/- ##
=======================================
Coverage 19.69% 19.69%
=======================================
Files 8 8
Lines 2600 2600
=======================================
Hits 512 512
Misses 1985 1985
Partials 103 103 ☔ View full report in Codecov by Sentry. |
|
Did we see these errors in the test logs in the last few days? Or how have you noticed it? |
milan-zededa
reviewed
Sep 2, 2024
| // Make sure that the interface is UP right after MAC address assignment | ||
| // and interface rename. In case of incorrect order operation fails | ||
| // with `Device or resource busy`. | ||
| if err := netlink.LinkSetUp(link); err != nil { |
There was a problem hiding this comment.
I suggest to put this at the end (after LinkSetUp(bridge)) and with kernLink as the argument. In the past I saw LinkSetMaster changing the interface status to DOWN.
rouming
force-pushed
the
mac-addr-while-eth-down
branch
from
8e93369 to
5d0f018
Compare
milan-zededa
reviewed
Sep 2, 2024
…le interface is DOWN On attempt to set MAC address or rename interface which is UP host returns `Device or resource busy`. Patch fixes the error by changing the order: first set MAC and rename interface, then bring interface UP. Patch fixes inability to use host interface, the problem was reproduced on RPI4 board. Presumably any device should be affected. Signed-off-by: Roman Penyaev <[email protected]> Fixes: 7a6981b ("Add support for switch network instance with multiple ports")
rouming
force-pushed
the
mac-addr-while-eth-down
branch
from
5d0f018 to
52fdb5d
Compare
milan-zededa
approved these changes
Sep 2, 2024
|
@eriknordmark Please do not make EVE release until we merge this. |
|
Have just updated the "Radiatore" board (in Berlin-Lab), all good, keth0 appeared. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On attempt to set MAC address or rename interface which is UP host returns
Device or resource busy. Patch fixes the error by changing the order: first set MAC and rename interface, then bring interface UP.Patch fixes inability to use host interface, the problem was reproduced on RPI4 board. Presumably any device should be affected.
Fixes: 7a6981b ("Add support for switch network instance with multiple ports")
PS. This PR is not tested. Need some comments from Milan, will do testing next week.